Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTokenNames / getTokens don't work with mapName option #1175

Closed
Merudo opened this issue Jan 22, 2020 · 2 comments
Closed

getTokenNames / getTokens don't work with mapName option #1175

Merudo opened this issue Jan 22, 2020 · 2 comments
Assignees
@Merudo
Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented Jan 22, 2020 •
edited
Loading

Describe the bug
getTokenNames / getTokens don't work with mapName option anymore, because extra "s are added around the value of the mapName parameter.

To Reproduce
Steps to reproduce the behavior:

  1. Create a project with the Grasslands map.
  2. Type the following in MapTool 1.5.11 beta 1 or develop (1/22/2020)
    [h: cond = json.set("{}", "mapName", "Grasslands")][r: getTokenNames(",",cond)]
  3. Notice the error message:
    Can not find map ""Grasslands"" in function "getTokenNames".

Expected behavior
The map is properly found.

MapTool Info

  • Version: 1.5.11 beta 1, develop (1/22/2020)
  • Install: New

Desktop (please complete the following information):

  • OS: Windows
  • Version: 10
Merudo added a commit to Merudo/maptool that referenced this issue Jan 22, 2020
@Merudo
Fix getTokens not working with mapName option
1ebd5d7 
- Fix RPTools#1175
Merudo added a commit to Merudo/maptool that referenced this issue Jan 22, 2020
@Merudo
Fix getTokens not working with mapName option
c1e076d 
- Fix RPTools#1175
@Merudo Merudo mentioned this issue Jan 22, 2020
Merged
@Merudo
Copy link
Member Author

Merudo commented Jan 22, 2020

PR #1176 fixes this.

@Phergus Phergus added bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) labels Jan 22, 2020
@Phergus
Copy link
Contributor

Phergus commented Jan 22, 2020

Tested. Working as expected now.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Jan 22, 2020
@Phergus Phergus closed this as completed Jan 23, 2020
Phergus added a commit that referenced this issue Jan 23, 2020
@Phergus
Update Change Log with latest
5af59a6 
Added: #413, #1165, #1167, #1173, #1175, #1177, #1178
@Phergus Phergus mentioned this issue Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
bug macro changes This issue adds or changes macro functions. Extra work is required (testing, wiki, code editor) tested This issue has been QA tested by someone other than the developer.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus