-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Change Log with latest #1183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Phergus)
CHANGE_LOG.md, line 8 at r1 (raw file):
- Tokens can be set to ignore Terrain Modifiers. - Per map setting for rounding of fractional movement costs: NONE, CELL_UNIT, INTEGER - Can now specify a campaign file on startup either the File Assocation on Windows or via command line option `-F/-file=...`.
It's allowed to be a parameter without any option at all. File associations do that on Windows, but so does dragging and dropping a file on top of the executable on Linux and macOS. Either specify all of them, or reduce it to just "-F or as command line parameter"?? (Or don't change it at all. Just an observation.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Azhrei)
CHANGE_LOG.md, line 8 at r1 (raw file):
Previously, Azhrei (Frank Edwards) wrote…
It's allowed to be a parameter without any option at all. File associations do that on Windows, but so does dragging and dropping a file on top of the executable on Linux and macOS. Either specify all of them, or reduce it to just "-F or as command line parameter"?? (Or don't change it at all. Just an observation.)
Yeah. I didn't want to make it two paragraphs of explanation as no one reads anything more than a single line in length. Dragging/dropping works the same on all three platforms. Your PR didn't mention if file association or drag-n-drop working on Mac so I didn't want to assume. I'll rework though for clarity.
Edit for clarity on campaign file startup support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
More clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Added: #413, #1165, #1167, #1173, #1175, #1177, #1178
This change is