Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Maintenance: Replace UTF-8 by StandardCharsets.UTF_8 #1352

Closed
Merudo opened this issue Mar 4, 2020 · 2 comments
Closed

Code Maintenance: Replace UTF-8 by StandardCharsets.UTF_8 #1352

Merudo opened this issue Mar 4, 2020 · 2 comments
Assignees
@Merudo
Labels
code-maintenance Adding/editing javadocs, unit tests, formatting. feature Adding functionality that adds value

Comments

@Merudo
Copy link
Member

Merudo commented Mar 4, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
There are quite a few places using a "UTF-8" string for encoding/decoding.

These should be replaced by the constant StandardCharsets.UTF_8. This leads to cleaner code, and in some cases allows us to remove a bogus try/catch for an UnsupportedEncodingException that cannot happen.
@Phergus Phergus added code-maintenance Adding/editing javadocs, unit tests, formatting. feature Adding functionality that adds value labels Mar 4, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Mar 4, 2020
@Merudo
Replace "UTF-8" String by StandardCharsets.UTF_8
2290c1d 
- Replace UTF-8 String by StandardCharsets.UTF_8
- Remove all UnsupportedEncodingException try/catch
- Close RPTools#1352
@Merudo Merudo mentioned this issue Mar 4, 2020
Merged
@Merudo
Copy link
Member Author

Merudo commented Mar 4, 2020

PR #1354 implements this change.

@Phergus
Copy link
Contributor

Phergus commented Mar 5, 2020

No adverse effects seen. Closing.

@Phergus Phergus closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merudo Merudo

Labels
code-maintenance Adding/editing javadocs, unit tests, formatting. feature Adding functionality that adds value
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Merudo @Phergus