Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "UTF-8" String by StandardCharsets.UTF_8 #1354

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Replace "UTF-8" String by StandardCharsets.UTF_8 #1354

merged 2 commits into from
Mar 4, 2020

Conversation

Merudo
Copy link
Member

@Merudo Merudo commented Mar 4, 2020 •
edited by cwisniew
Loading

This change is Reviewable

@Merudo
Replace "UTF-8" String by StandardCharsets.UTF_8
2290c1d 
- Replace UTF-8 String by StandardCharsets.UTF_8
- Remove all UnsupportedEncodingException try/catch
- Close RPTools#1352
@Merudo Merudo mentioned this pull request Mar 4, 2020
Closed
cwisniew
cwisniew approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@cwisniew cwisniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus Phergus merged commit 86cb9c4 into RPTools:develop Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwisniew cwisniew cwisniew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Merudo @cwisniew @Phergus