-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame property temporary=1 is ignored #585
Comments
Merudo
added a commit
to Merudo/maptool
that referenced
this issue
Aug 20, 2019
- Fix behavior with temporary=1 when the frame is closed through closeFrame() - Add variable "temporary" to getFrameProperties() - Does not fix behavior for closing by clicking on the close button - I don't know how to setup the WindowListener properly - Partially fix RPTools#585
I don't remember how to add the WindowListener to clear up the frame properties after clicking the "Close" button. Adding the following to the constructor did not work:
EDIT I think addDockableFrameListener() may need to be used. |
Merudo
added a commit
to Merudo/maptool
that referenced
this issue
Aug 20, 2019
- Add addDockableFrameListener to remove the frame after clicking the close button when temporary=1 - Fix RPTools#585
Figured it out. PR #596 fix it fully. |
Tested against 1.5.3 and 1.5.4 develop branch. Working as expected now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If a frame is opened with temporary=1; maptool still remembers the window size between openings
To Reproduce
Steps to reproduce the behavior:
[frame("Frame Test", "width=300; height=500; temporary=1;"): {A test} ]
Expected behavior
Maptool doesn't remember the size if temporary is set to 1.
MapTool Info
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: