Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to frame() partial support for "temporary" #593

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

Merudo
Copy link
Member

@Merudo Merudo commented Aug 20, 2019

  • Fix behavior with temporary=1 when the frame is closed through closeFrame()
  • Add field "temporary" to the json returned by getFrameProperties()
  • Does not fix behavior when clicking on the close button - I don't know how to setup the WindowListener properly
  • Partially fix Frame property temporary=1 is ignored #585

This change is Reviewable

- Fix behavior with temporary=1 when the frame is closed through closeFrame()
- Add variable "temporary" to getFrameProperties()
- Does not fix behavior for closing by clicking on the close button - I don't know how to setup the WindowListener properly
- Partially fix RPTools#585
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@JamzTheMan JamzTheMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus Phergus merged commit 986878a into RPTools:develop Aug 20, 2019
@Merudo Merudo deleted the frameTemporary branch August 20, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants