Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.13 #1303

Merged
merged 19 commits into from
Feb 21, 2020
Merged

Release 1.5.13 #1303

merged 19 commits into from
Feb 21, 2020

Conversation

JamzTheMan
Copy link
Member

@JamzTheMan JamzTheMan commented Feb 20, 2020

This change is Reviewable

JamzTheMan and others added 18 commits December 12, 2019 18:10
…croFunctions.java

Co-Authored-By: Guillaume F. <filteau.guillaume@gmail.com>
… method

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Issues 1204, 1206, 1228, 1236.
 * Now gracefully handles NPE and inserts error message as the XML

Fixes #1296

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
 * Now gracefully handles NPE and inserts error message as the XML
 * Update to <error /> tag

Fixes #1296

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
Bug fix for NPE when Hero Lab XML data missing
- Fix similar issues for "light", "propertyType", and "owner" options
- Fix #1292
Copy link
Member Author

@JamzTheMan JamzTheMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r9, 1 of 3 files at r10.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@JamzTheMan JamzTheMan requested a review from Phergus February 21, 2020 00:33
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Phergus)

@Phergus Phergus merged commit 5f448a0 into develop Feb 21, 2020
@Phergus Phergus deleted the rel-1.5.13 branch February 21, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants