Improve bool parsing as XML can support also 0/1 value as bool #88
Conversation
|
In #51 a test was requested to complete the feature. I added a test that deserializes |
| test_parse_ok(&[ | ||
| ("<bla>true</bla>", true), | ||
| ("<bla>false</bla>", false), | ||
| ("<bla> true </bla>", true), | ||
| ("<bla> false </bla>", false), | ||
| ("<bla>1</bla>", true), | ||
| ("<bla>0</bla>", false), | ||
| ]); |
There was a problem hiding this comment.
Can you also add a test for the error case please?
src/de/mod.rs
Outdated
| match s.as_str() { | ||
| "true" | "1" => visitor.visit_bool(true), | ||
| "false" | "0" => visitor.visit_bool(false), | ||
| _ => Err(ErrorKind::UnexpectedToken( |
There was a problem hiding this comment.
Maybe better to use Error::unknown_variant or Error::invalid_value here.
There was a problem hiding this comment.
@RReverser, are you suggesting creating a new ErrorKind?
There was a problem hiding this comment.
Missed this. No, I meant using Serde's own method.
There was a problem hiding this comment.
Thanks. I chose Error::invalid_value.
This reverts commit e39a9b8.
|
(approved; as a reminder, please clean up history a bit before merging) |
Improve bool parsing as XML can support also 0/1 value as bool
Continuation of #51