Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bool parsing as XML can support also 0/1 value as bool #88

Merged
merged 10 commits into from
Mar 11, 2019
Merged

Improve bool parsing as XML can support also 0/1 value as bool #88

merged 10 commits into from
Mar 11, 2019

Commits on Jan 17, 2019

  1. Add test for parsing 0,1 as boolean

    William Bartlett committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    66cfe38 View commit details
    Browse the repository at this point in the history

  2. improve bool parsing as XML can support also 0/1 value as bool

    @MarcAntoine-Arnaud
    MarcAntoine-Arnaud authored and William Bartlett committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    1d89492 View commit details
    Browse the repository at this point in the history

  3. Make bool parsing error explicit

    William Bartlett committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    0539280 View commit details
    Browse the repository at this point in the history

  4. Fix

    William Bartlett committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    f282060 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. Create new error kind for invalid boolean values.

    William Bartlett committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    e39a9b8 View commit details
    Browse the repository at this point in the history

  2. Test for invalid boolean values.

    William Bartlett committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    41e5247 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge remote-tracking branch 'RReverser/master' into feature/boolean-01

    William Bartlett committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f6ebe71 View commit details
    Browse the repository at this point in the history

  2. Fix "conflict"

    William Bartlett committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    9d0313d View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Revert "Create new error kind for invalid boolean values." 

    This reverts commit e39a9b8.
    William Bartlett committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    a6128a9 View commit details
    Browse the repository at this point in the history

  2. Use serde::de::Error::invalid_value

    William Bartlett committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    027cfff View commit details
    Browse the repository at this point in the history