-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Facebook Titles: mod #454
Comments
Nice work @ghostofzigz 👍 I haven't tested it on my machine yet, but can this be made compatible to all languages (I assume this will only work for English Facebook)? Also, is there any particular reason to wrap lines at 24/64 characters or is it made to your specific needs? |
I will take another look at simplifying the regex to eliminate language specific patterns... unfortunately at this time it looks like Facebook is blocking ALL requests via the RSS Bridge, so I will need to hack the request URL for this module to continue automated testing. The reason for the 24 and 64 length limits was for compatibility with the code I was replacing (wasn't sure the reason for that either, figured it may come into play in other parts of the application adding to the title, and twitter length limits). |
Closing because Facebook titles were fixed a long time ago. |
A slightly improved version of RSS-Bridge#454 and RSS-Bridge#468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful).
UPDATED Jan 12, 2017 (working well)
My News Aggrigation application filters by title. The titles coming from the FacebookBridge are mostly NON-unique. Here is an update to the FacebookBridge title section which gives a far more descriptive title and attempts to make it unique if there is not enough data:
On or near line 150 find the following
AFTER THIS, add:
On or near Line 210 change:
To:
I also have a shell script to automate this update for whenever the RSS-Bridge code is updated from here... if anyone would like that, get at me.
-- ghostofzigz
The text was updated successfully, but these errors were encountered: