Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FacebookBridge] Better titles #924

Merged
merged 3 commits into from
Nov 16, 2018
Merged

[FacebookBridge] Better titles #924

merged 3 commits into from
Nov 16, 2018

Conversation

triatic
Copy link
Contributor

@triatic triatic commented Nov 15, 2018

A slightly improved version of #454 and #468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful or unique).

A slightly improved version of #454 and #468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful).
Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Find below a few comments.

bridges/FacebookBridge.php Outdated Show resolved Hide resolved
bridges/FacebookBridge.php Outdated Show resolved Hide resolved
logmanoriginal and others added 2 commits November 15, 2018 21:41
Co-Authored-By: triatic <42704418+triatic@users.noreply.github.com>
Co-Authored-By: triatic <42704418+triatic@users.noreply.github.com>
@triatic
Copy link
Contributor Author

triatic commented Nov 15, 2018

Thanks for the suggestions, I've committed them.

@logmanoriginal logmanoriginal merged commit 3806895 into RSS-Bridge:master Nov 16, 2018
@logmanoriginal
Copy link
Contributor

Merged. Thanks again for improving the bridges! 👍

@triatic triatic deleted the patch-7 branch November 21, 2018 16:36
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
A slightly improved version of RSS-Bridge#454 and RSS-Bridge#468 . Build titles from content rather than author + pre-content (which doesn't reflect anything useful).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants