[BridgeAbstract] Add per-bridge configuration support #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed complicated array_key_exists() construct to a straitforward isset() check to satisfy the same purpose without causing a warning if self::$config is missing for some reason.
|
Weird that Travis complains about some bridges not in the scope of this PR, it didn't on my local instance. |
Co-Authored-By: LogMANOriginal <LogMANOriginal@users.noreply.github.com>
|
I guess the aim of #1343 was to superseed this, I will try to work on it as soon as I am able to. |
😮 You are right, I totally forgot about that one, sorry. |
|
@teromene Me too, sorry about that. |
|
Closed in favor of #1343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1170.
Bridges like the Twitch or YouTube API bridge (#1272), that need some kind of global configuration, may benefit from it. If you have any suggestions or comments, don't hesitate to post below.