Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add configuration for bridges, allowing private bridges #1343

Merged
merged 5 commits into from
Dec 12, 2020

Conversation

teromene
Copy link
Member

@teromene teromene commented Oct 28, 2019

Starting to work on option for bridges, in the same way as the PARAMETERS array, expanding on what @fulmeek did.
In order for this to work, it works this way:
You create an optional array, named CONFIGURATION:

	const CONFIGURATION = array(
			'api_key' => array(
				'required' => true,
			),
                       'api_key_can_fetch_images' => array(
                                'required' => false,
                                'defaultValue' => 'no',
                       )
	);

The configuration can then be put in the configuration, like this:

; --- Bridge Specific Options ---------------------------------------------------
[MyBridge]
api_key = "eeeeeeeeee"

If a bridge is in the whitelist, but the configuration options that are marked as required, then the bride will not be loaded. This allows for integration of private bridges without having to worry on hosts where all bridges are enabled.

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution 👍
I like that it works similar to PARAMETERS which makes it easy to get used to.

Find below a few comments.

lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Outdated Show resolved Hide resolved
lib/BridgeAbstract.php Show resolved Hide resolved
lib/BridgeList.php Outdated Show resolved Hide resolved
@Peterr-K
Copy link
Contributor

Peterr-K commented Aug 24, 2020

Is this pull request ready guys? we need it, as Instagram is showing for blacklisted IPs login windows instead of a channel. thanks.

@teromene teromene marked this pull request as ready for review December 9, 2020 08:38
@teromene
Copy link
Member Author

teromene commented Dec 9, 2020

I have taken the review in account and am ready to merge.

@em92 em92 merged commit 810a250 into RSS-Bridge:master Dec 12, 2020
@em92
Copy link
Contributor

em92 commented Dec 12, 2020

Thank you @teromene !

@TwizzyDizzy
Copy link
Contributor

Ah, that's a neat new feature! Thank you all! :)

Cheers
Thomas

xthursdayx added a commit to xthursdayx/rss-bridge that referenced this pull request Sep 15, 2021
Not sure if this will work or not, but trying to use PR RSS-Bridge#1343 to add access to private Patreon feeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants