Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FilterBridge] Various improvements #2148

Merged
merged 4 commits into from
Jun 7, 2021
Merged

[FilterBridge] Various improvements #2148

merged 4 commits into from
Jun 7, 2021

Conversation

ORelio
Copy link
Contributor

@ORelio ORelio commented Jun 5, 2021

I'm using the Filter bridge to hide ads, sponsored articles and was missing a few features.
Here are a few improvements for the Filter bridge:

  • Add option for case-insensitive regex
  • Allow matching item content instead or in addition to item title
  • Optionally attempt to convert encoding when applying matches

The changes should be backward-compatible with existing feeds based on the Filter bridge.
I tested the changes on my instance for a few days to check everything was working as expected.

- Add option for case-insensitive regex
- Allow matching item content instead or in addition to item title
- Optionally attempt to convert encoding when applying matches
@ORelio
Copy link
Contributor Author

ORelio commented Jun 5, 2021

(Please squash commits when merging)

bridges/FilterBridge.php Outdated Show resolved Hide resolved
Use separate checkboxes for title, content, author
Change order in bridge card to make options clearer
Change max length to apply to all fields instead of only content
@ORelio ORelio requested a review from em92 June 6, 2021 13:36
@em92
Copy link
Contributor

em92 commented Jun 7, 2021

Hello, @captn3m0 !
This is what you asked #1960

@em92 em92 merged commit 75cc52a into RSS-Bridge:master Jun 7, 2021
@em92
Copy link
Contributor

em92 commented Jun 7, 2021

gj @ORelio !

@Frenzie Frenzie mentioned this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants