-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arte7Bridge] Support all languages #2543
Conversation
Pull request artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the limit, this looks fine.
This will break backwards compatibility, but I am a fan of making the bridge easier to maintain (no specific contexts for each language) and also adding basically 200% more languages.
I'll let @em92 decide because of seniority. But I think if we do this big cleanup, a few bridges backwards compat will be broken. And this bridge pr definitely comes with benefits.
bridges/Arte7Bridge.php
Outdated
break; | ||
} | ||
|
||
$url = 'https://api.arte.tv/api/opa/v3/videos?sort=-lastModified&limit=10&language=' | ||
$url = 'https://api.arte.tv/api/opa/v3/videos?sort=-lastModified&limit=100&language=' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$url = 'https://api.arte.tv/api/opa/v3/videos?sort=-lastModified&limit=100&language=' | |
$url = 'https://api.arte.tv/api/opa/v3/videos?sort=-lastModified&limit=15&language=' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not 100. Even 15 cover more than a month in all tested contexts (see bot commet). There is no reason to pull 100 items on every refresh.
Also increase limit to 15. Based on code by mitsukarenai from https://gist.github.com/mitsukarenai/93c12e1470e2b731d64a31dffbe46075 Fixes RSS-Bridge#1906.
f19f5ba
to
ef6691e
Compare
Thanks, I changed the limit to 15. |
We've broken multiple backwards compatibilities for the cleanup action, so I'm merging this. |
This PR adds support for all languages in arte.tv. I've used this for a while, and it works ok, at least for some value of 'works'.
Based on code by mitsukarenai from
https://gist.github.com/mitsukarenai/93c12e1470e2b731d64a31dffbe46075
This has never been tested with the web interface, I have generated local rss-files with commands like this:
I basically don't know PHP at all, so I'm not going to maintain this code.
Also increases the limit to 100.
Fixes #1906.