Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Japanese translations for user actions and login prompts #2188

Merged
merged 37 commits into from
Dec 17, 2024

Conversation

dai
Copy link
Contributor

@dai dai commented Dec 17, 2024

This pull request involves updates to Japanese translations across multiple JSON files, improving the clarity and consistency of various user interface elements.

Translation Updates:

dai and others added 30 commits November 11, 2024 11:47
chore: update and bump 6 ja.json files.
Merge branch 'RSSNext:dev' into dev
fix locale/error/ja.json
update settings/ja.json
so sorry, @hyoban 😢

Perhaps my local settings are in. I have restored it to the original. Thanks for your kindness. 
You have always been a great help.
sync and update settings/ja.json
@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Dec 17, 2024

@dai is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix(locales): update Japanese locale files for clarity

Change Summary:
Updated Japanese translations across app, external, and settings locales with new phrases and improved clarity. Key additions include better login prompts, password management terms, and adjustments for improved flow in user experience.

Code Review:
No change requests necessary.

@hyoban
Copy link
Member

hyoban commented Dec 17, 2024

A small suggestion, you can check out a branch from the dev branch of the fork to submit a PR, and then the dev branch is used to synchronize with the upstream. This can make your PR commit tidy

@dai
Copy link
Contributor Author

dai commented Dec 17, 2024

A small suggestion, you can check out a branch from the dev branch of the fork to submit a PR, and then the dev branch is used to synchronize with the upstream. This can make your PR commit tidy

Thanks again, ひょうばんさん(Hyoban-san).

I appreciate the suggestion, I'll do so next time!

"profile.sidebar_title": "プロフィール",
"profile.submit": "送信",
"profile.title": "プロフィール設定",
"profile.updateSuccess": "プロフィールが更新されました。",
"titles.about": "アバウト",
"profile.update_password_success": "パスワードが更新されました。",
"titles.about": "about",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this line changed back to English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many Japanese style guides prefer to leave it as “about”. Or it could be translated as “バージョン情報” or “Follow について” but the word “アバウト” is not very appropriate.
I'd prefer "about" as a fit.

image

@Innei Innei merged commit 88458bd into RSSNext:dev Dec 17, 2024
4 of 7 checks passed
@follow-reviewer-bot
Copy link

Thank you @dai for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants