Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issue with displaying multiple source_record_urls #2346

Closed
amykglen opened this issue Aug 9, 2024 · 3 comments
Closed

UI issue with displaying multiple source_record_urls #2346

amykglen opened this issue Aug 9, 2024 · 3 comments
Assignees
Labels

Comments

@amykglen
Copy link
Member

amykglen commented Aug 9, 2024

I noticed in the UI (arax.ncats.io/beta) that when there are multiple source_record_urls (which is a list data type) on an edge source, the UI displays and hyperlinks them as one link - see red hyperlink below:

Screenshot 2024-08-08 at 8 05 21 PM the URL it tries to send you to in that example is:

https://db.systemsbiology.net/gestalt/cgi-pub/KGinfo.pl?id=d67d8173-eea6-3d19-a33c-35b2c0119e3b,https://db.systemsbiology.net/gestalt/cgi-pub/KGinfo.pl?id=ffcd1fe3-d9e8-36e2-8e9a-72f8fd1deccf

which unsurprisingly gives an error

but I can see in the raw JSON that the URLs are indeed separate items in a list, as they're supposed to be:

            {
              "resource_id": "infores:multiomics-clinicaltrials",
              "resource_role": "aggregator_knowledge_source",
              "upstream_resource_ids": [
                "infores:aact"
              ],
              "source_record_urls": [
                "https://db.systemsbiology.net/gestalt/cgi-pub/KGinfo.pl?id=d67d8173-eea6-3d19-a33c-35b2c0119e3b",
                "https://db.systemsbiology.net/gestalt/cgi-pub/KGinfo.pl?id=ffcd1fe3-d9e8-36e2-8e9a-72f8fd1deccf"
              ]
            }

I don't have an ARAX/ARS response id to share for this example, sorry - I ran this query by setting the External API to https://ctkp.rtx.ai:9990 in the Settings tab in the UI and then doing 'Post to OTHER' for this query:

{
  "edges": {
    "e00": {
      "subject": "n00",
      "object": "n01",
      "predicates": [
        "biolink:in_clinical_trials_for"
      ]
    }
  },
  "nodes": {
    "n00": {
      "ids": [
        "UNII:TS63EW8X6F"
      ]
    },
    "n01": {
      "ids": [
        "MONDO:0005148"
      ]
    }
  }
}

thanks!

@isbluis
Copy link
Member

isbluis commented Aug 9, 2024

Hi @amykglen . Thanks for the report; always hard to code when there is not set datatype in the schema!
I have a fix in devLM; let me know if you are able to have a look and whether I broke something else in the process :)
https://arax.ncats.io/devLM/index.html

@amykglen
Copy link
Member Author

amykglen commented Aug 9, 2024

it looks great, thanks!

isbluis added a commit that referenced this issue Sep 9, 2024
- Restore loading of a response via URL (via magic "hhttp" prefix)
- For very long queries, show the number of days it has been running (if > 1) in System Activity
isbluis added a commit that referenced this issue Sep 14, 2024
- Add quick-links to external URLs for ClinicalTrials and DrugApprovals KPs in Settings (#2346)
- Update some of those URLs to TRAPI 1.5 endpoints
- Update ARAXi DSL helper JSON
- Add "Total" row to Testing summary view
@isbluis
Copy link
Member

isbluis commented Sep 17, 2024

Closing

@isbluis isbluis closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants