Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect parameter assignment in ThermalZone for internal gains persons #1248

Closed
KremerMartin opened this issue Mar 31, 2022 · 3 comments
Closed

Incorrect parameter assignment in ThermalZone for internal gains persons #1248

KremerMartin opened this issue Mar 31, 2022 · 3 comments
Assignees
@KremerMartin
Labels
bug

Comments

@KremerMartin
Copy link
Contributor

Describe the bug
In the thermal zone model the parameter for dividing the heat flow of the persons is assigned incorrectly. It is linked to the paramter ratioConvectiveHeat, but the parameter responsible for dividing the heat flow is ratioConv.

To Reproduce
Steps to reproduce the behavior:

  1. Go to AixLib.ThermalZones.ReducedOrder.Examples.ThermalZone
  2. Take a look at the zoneParams declaring the ratioConvectiveHeatPeople as 0.5.
  3. Double-click on the Human-Model HumanSensibleHeatTemperatureDependent declaring the parameter ratioConv constantly to 0.6.
  4. Simulate the example and plot thermalZone.humanSenHeaDependent.convectiveHeat.Q_flow and thermalZone.humanSenHeaDependent.radiativeHeat.Q_flow. There not equal but should be since the zoneParam declares the ratio to 0.5.

Expected behavior
Radiative heat flow and convective heat flow should be equal.

Screenshots
grafik
@KremerMartin
Copy link
Contributor Author

KremerMartin commented Mar 31, 2022 •
edited
Loading

The solution will be to assign the zoneParam.ratioConvectiveHeatPeople to the parameter ratioConv and delete the parameter ratioConvectiveHeat.
@DaJansenGit and @MartinRaetz: Do you remember why we chose the other parameter instead of ratioConv when reforming the internal gains 3 years ago? Or did this bug occur during the reformation of the internal gains carried out by @PMehrfeld?
I think, he changed the model AixLib.BoundaryConditions.InternalGains.BaseClasses.PartialInternalGain in 2020.

@KremerMartin KremerMartin self-assigned this Mar 31, 2022
@KremerMartin
Copy link
Contributor Author

I have found the commit (2e508c5dc20a8293c48c71e2740ba239a9673a54), where the extension of the AixLib.BoundaryConditions.InternalGains.Humans.BaseClasses.PartialHuman from the AixLib.BoundaryConditions.InternalGains.BaseClasses.PartialInternalGain was carried out. Since then, the parameter ratioConvectiveHeat is not used anymore. Instead the parameter ratioConv from the AixLib.BoundaryConditions.InternalGains.BaseClasses.PartialInternalGain is used. Since then the parameter is not assigned to the zone param.

KremerMartin pushed a commit that referenced this issue Mar 31, 2022
@martinkremer
Deletes parameter ´ratioConvectiveHeat´, updates ´ThermalZone´
9d44403 
For #1248
@KremerMartin KremerMartin mentioned this issue Mar 31, 2022
Merged
KremerMartin pushed a commit that referenced this issue Apr 1, 2022
@martinkremer
[skip-ci] Add conversion script and increase AixLib-version
817f3fd 
For #1248
@KremerMartin
Copy link
Contributor Author

closed by PR #1249

larissakuehn added a commit that referenced this issue Aug 8, 2022
@larissakuehn @FelixStege
@alexanderAKU @martinkremer @DaJansenGit @FWuellhorst @SvenHinrichs @KremerMartin @tobinfiedler
Merge for release 1.3.0 (#1318)
098f613 
* Add discretization of volumes

* Change lambda for more realistic thermal wave propagation

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/i1227_SimplePipeVolume/plots/ [skip ci]

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/i1227_SimplePipeVolume/plots/ [skip ci]

* [skip ci]

* #784 plot script for unit test has been added

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue784_AhuWithHydraulicModules/plots/ [skip ci]

* push latest changes

* chore: wall names

* refactor airload, fix names and extend walls

* Fixes wrong connection of fluid ports

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1123_partialHOMModels/plots/ [skip ci]

* Adds moisture balance to partial room model.

* temp cmt

* Adds documentation for PartialRoom.mo

* Make four room partial model more dynamic and extend all relevant examples from it.

* add documentation #1123

* Revert changes

* Reverts change on port connection to airLoad (happened accidently)

* Make parameters optional

* Revert "Issue784 ahu with hydraulic modules"

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/revert-1039-issue784_AhuWithHydraulicModules/plots/ [skip ci]

* #784 changed parameter in DynamicHX.mo Gc1 and Gc2 to type thermal coductance + use admix as predefined circuit in RegisterModule.mo

* "ci_regression_test"

* Add fitting description [skip ci] #1215

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1215_internalGainsOuput/plots/ [skip ci]

* chore: trigger change

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/development_update/plots/ [skip ci]

* chore: trigger pipeline again

* Fix Regression errors

* feat: move NCDataReader to obsolete

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/development_update/plots/ [skip ci]

* feat: remove submodule for NetCFD reader as NCdatareader is now obsolete

* Fix conditional case

* Remove failing examples due to obsolete models #1179

* rm unwanted mos and ref-results

* Delete results to trigger update

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1123_partialHOMModels/plots/ [skip ci]

* trigger pipeline

* Fix energyDynamics of old model

* Fix init problem in OFDHeatLoad.mo

* fix initial conditions, this time for real

* rm reference result to update

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1123_partialHOMModels/plots/ [skip ci]

* Changed documentation slightly to trigger CI

* Deletes parameter ´ratioConvectiveHeat´, updates ´ThermalZone´

For #1248

* [skip-ci] Add conversion script and increase AixLib-version

For #1248

* Delete reference results to trigger update

* Correct typo in package.mo

* Create github-action-slack.yml

* #784 add modular AHU model and controller models after revert

* #784 plot scripts for modular ahu added

* #784 plot script setup modified of GenericAHU.mos

* #784 genericAHU: typo in annotations fixed

* #784 start values for m_flow nominal in generic ahu to avoid warnings

* Update Templates, Script: IBPSA Merge with Image Dymola 2020 with MSL 4.0

* Update IBPSA Merge template

* Update validatetest script

* Update WhiteList_CheckModel.txt and HTML_IBPSA_WhiteList.txt

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* fix errors manually

* Fix errors manually

* fix errors manually

* fix errors manually

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/ [skip ci]

* ci_regression_test

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/ [skip ci]

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* Fix script annotation

* Trigger IBPSA Merge

* Update WhiteList_CheckModel.txt and HTML_IBPSA_WhiteList.txt

* fix errors manually

* ci_check

* ci_check

* ci_check

* Update Slack Scripts

* #784 plot script GenericAHU.mos modified

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue784_AhuWithHydraulicModules/plots/ [skip ci]

* fix errors manually

* fix errors manually

* fix errors manually

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue784_AhuWithHydraulicModules/plots/ [skip ci]

* #784 temperatures in AHUbus renamed

* #784 bug fix in plot script due to renaming of air temperatures

* #784 reference results updated

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue784_AhuWithHydraulicModules/plots/ [skip ci]

* Add Issue Tracker

* Fix in github action script

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_regression_test

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_regression_test

* lower case for simlate and plot script command

* lower case for simlate and plot script command

* Update WhiteList_CheckModel.txt and HTML_IBPSA_WhiteList.txt

* fix errors manually

* ci_update_ref

* ci_update_ref

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_update_ref

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_update_ref

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_regression_test

* ci_simulate

* ci_regression_test

* remove .github/README.md

* remove ci_slack_branch_inactive_list.txt

* ci_regression_test

* ci_regression_test

* ci_update_ref

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* #1122 default for natural infiltration equals default for mechanical ventilation for conversion [scip ci]

* ci_regression_test

* #1122 Correct connections [scip ci]

* #1122 Change affected examples [scip ci]

* ci_regression_test

* ci_regression_test

* ci_regression_test

* #1122 add conversion script

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* Update google_charts.py script

* #1122 fix errors in multizone and apply equivalent changes as in thermal zone

* fix errors

* #1122 remove unnecessary comments [scip ci]

* #1122 change parameter description [scip ci]

* #1122 changed version specifier to 1.0.4 [scip ci]

* #1122 correction of annotations

* Change Templates

* fix errors manually

* fix errors manually

remove AixLib.Systems.HydraulicModules.Example.Pump from whitelist as it should be fixed

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* ci_regression_test

* Update templates: Change to xvfb-run -n 77

* Update templates: Change to xvfb-run -n 77

* Update templates: Change to xvfb-run -n 77

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* ci_update_ref

* ci_update_ref

* Automatic push of CI with updated or new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/IBPSA_Merge/plots/

* temp deactivate issue tracker workflow 

This currently leads to problems with doubled branches  because automatic creation of branches might create doubled branches (case sensitivity)

* Delete issue-tracker.yml

Disabling does not work and results in error emails to people who push content.

* Add script, move to obsolete #978

* Fix gitlab templates

* Change command convertClass to ConvertModifiers

* Add new development stage in gitlab tempaltes

* Change in template check_model

* Actually delete files

* Test Changes in regression templates

* Test Changes in regression templates

* Automatic push of CI with new regression reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/Issue1313_fix_RegressionTest_Check_References/plots/

* Added a medium choice in PartialRoom (HOM) (#1303)

* Added a medium choice in PartialRoom (HOM)

Furthermore a model for air with co2 was added to the selection in PartialRoom

* Reverted not necessary changes

* Minor Changes

- changed the name of the new medium parameter
- deleted unused medium parameters (Water and Glycol/Water mixture)

Co-authored-by: fabian.wuellhorst <fabian.wuellhorst@rwth-aachen.de>

* Update version to 1.3.0 for new release

Co-authored-by: FelixStege <felix.stegemerten@rwth-aachen.de>
Co-authored-by: ebc-aixlib-bot <hinrichs-sven@gmx.de>
Co-authored-by: FelixStege <38731996+FelixStege@users.noreply.github.com>
Co-authored-by: Alexander Kümpel <alexander.kuempel@rwth-aachen.de>
Co-authored-by: A. Kuempel <AKuempel@eonerc.rwth-aachen.de>
Co-authored-by: fabian.wuellhorst <fabian.wuellhorst@rwth-aachen.de>
Co-authored-by: Martin Kremer <martin.theodor.kremer@rwth-aachen.de>
Co-authored-by: David Jansen <david.jansen@eonerc.rwth-aachen.de>
Co-authored-by: David <david.jansen1@rwth-aachen.de>
Co-authored-by: FWuellhorst <fabian.wuellhorst@eonerc.rwth-aachen.de>
Co-authored-by: SvenHinrichs <40233057+SvenHinrichs@users.noreply.github.com>
Co-authored-by: SvenHinrichs <sven.hinrichs@rwth-aachen.de>
Co-authored-by: Martin Kremer <48821826+KremerMartin@users.noreply.github.com>
Co-authored-by: tobinfiedler <73986053+tobinfiedler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KremerMartin KremerMartin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KremerMartin