Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1248 Solve incorrect parameter assignement in Thermal Zone for human internal gains #1249

Merged
merged 4 commits into from
May 2, 2022
Merged

Issue1248 Solve incorrect parameter assignement in Thermal Zone for human internal gains #1249

merged 4 commits into from
May 2, 2022

Conversation

KremerMartin
Copy link
Contributor

For #1248

@KremerMartin KremerMartin self-assigned this Mar 31, 2022
@ebc-aixlib-bot
Copy link
Contributor

Errors in regression test. Compare the results on the following page
https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/issue1248_incorrectParameterAssignmentHumanModel/plots

@KremerMartin KremerMartin requested a review from DaJansenGit April 1, 2022 07:14
DaJansenGit
DaJansenGit approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@DaJansenGit DaJansenGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this bug! Everything looks fine and the CI passes. You can merge this! 👍

@KremerMartin KremerMartin merged commit 3bdbd17 into development May 2, 2022
@KremerMartin KremerMartin deleted the issue1248_incorrectParameterAssignmentHumanModel branch May 2, 2022 16:17
@KremerMartin KremerMartin mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaJansenGit DaJansenGit DaJansenGit approved these changes

Assignees

@KremerMartin KremerMartin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KremerMartin @ebc-aixlib-bot @DaJansenGit @martinkremer