Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low Order Building Model collective issue #770

Closed
6 tasks done
DaJansenGit opened this issue Sep 16, 2019 · 6 comments
Closed
6 tasks done

Low Order Building Model collective issue #770

DaJansenGit opened this issue Sep 16, 2019 · 6 comments
Assignees
@DaJansenGit @MartinRaetz @KremerMartin
Labels
development Models which should be taken to development in the near future. enhancement hackday
Milestone
v0.8.0

Comments

@DaJansenGit
Copy link
Member

DaJansenGit commented Sep 16, 2019 •
edited
Loading

I want to collect all the ongoing issues for AixLib and TEASER due to the ongoing work for the internal gains changes, adding moisture and renaming multizone model at one place to have a better overview over the progress

AixLib

TEASER
@DaJansenGit DaJansenGit added this to the v0.8.0 milestone Sep 16, 2019
@DaJansenGit DaJansenGit added development Models which should be taken to development in the near future. enhancement labels Sep 16, 2019
@DaJansenGit DaJansenGit modified the milestones: v0.8.0, v0.9.0 Sep 16, 2019
@DaJansenGit
Copy link
Member Author

To finish this topic I would suggest the following way:

  1. wait until Enhance ROM (ThermalZone.RC) for moisture balance ibpsa/modelica-ibpsa#1209 is done
  2. create new branch for this issue Low Order Building Model collective issue #770 from development after Issue740 merge ibpsa #774 is done
  3. merge all above listed branches into Low Order Building Model collective issue #770
  4. merge Low Order Building Model collective issue #770 into development
  5. make a new release :)

you agree @KremerMartin

@KremerMartin
Copy link
Contributor

KremerMartin commented Oct 7, 2019 •
edited
Loading

@DaJansenGit I agree to that. I will do the pull request on ibpsa #1209 today.

@KremerMartin KremerMartin mentioned this issue Oct 7, 2019
Closed
@KremerMartin
Copy link
Contributor

The changes made on the ROM were merged in the IBPSA sub-branch issue1209_thermalMoistAir.
So we will need to wait until the changes are merged into the master of IBPSA to avoid merge conflicts updating our master.

@KremerMartin KremerMartin mentioned this issue Nov 12, 2019
Merged
KremerMartin pushed a commit that referenced this issue Nov 13, 2019
@martinkremer
Updates NamingConvention for MoistAirZones
af3e7e0 
Fixes Bug in HumanInternalGainModels -> set use_A_in = true

For #707 ,#770
KremerMartin pushed a commit that referenced this issue Nov 13, 2019
@martinkremer
Corrects Typo in HumanTotalHeat_TemperatureDependent
91e18c6 
For #770
@Dawac
Copy link
Contributor

Dawac commented Jan 6, 2020

Hi @KremerMartin and @DaJansenGit, how did this issue progress so far? Do you think this could be solved at our upcoming Hackday?

@DaJansenGit
Copy link
Member Author

Yes, it's our plan to close this issue during the hackday ;)

@DaJansenGit DaJansenGit mentioned this issue Jan 9, 2020
Closed
DaJansenGit added a commit that referenced this issue Jan 9, 2020
@DaJansenGit
Fix bugs with idealHeaterCooler & merge development into 770 #770 #841
0fb6dbc 
closes #841
@DaJansenGit DaJansenGit mentioned this issue Jan 9, 2020
Merged
KremerMartin pushed a commit that referenced this issue Jan 10, 2020
@martinkremer
Resolve review by M.Kremer [skip ci] #770
bdf2647
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
made RatioConvectiveHeat lowercase #770
d62eacd
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
make parameters and blocks start with lower case #770
7081958
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
resolve not nameSpace conform underscores #770
79c9559
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
remove more underscores and make more constants start with capital case
c6fa70a 
#770
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
refactor Heatport from Tempearture to T #770
6f3abb2
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
make blocks start with lower case #770
1a78a83
DaJansenGit added a commit that referenced this issue Jan 14, 2020
@DaJansenGit
Correct conditions, move IdealHeater parameters to partial #770
3022f8c 
- Correction of the conditions and adding a way to correctly
-  set conditions for PHeater and PCooler on multizone level dynamic by conditions on thermalzone level
- move idealHeaterCooler parameters to partial model for multizone model
@DaJansenGit
Copy link
Member Author

this is closed with dc57456

@DaJansenGit DaJansenGit mentioned this issue Jan 15, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaJansenGit DaJansenGit

@MartinRaetz MartinRaetz

@KremerMartin KremerMartin

Labels
development Models which should be taken to development in the near future. enhancement hackday
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
4 participants
@DaJansenGit @MartinRaetz @Dawac @KremerMartin