-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue695 add moisture balance thermal zone #815
Merged
KremerMartin
merged 91 commits into
issue770_LOMCollectiveIssue
from
issue695_AddMoistureBalanceThermalZone
Nov 12, 2019
Merged
Issue695 add moisture balance thermal zone #815
KremerMartin
merged 91 commits into
issue770_LOMCollectiveIssue
from
issue695_AddMoistureBalanceThermalZone
Nov 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other ReducedOrderModels volAir is redeclared using the definition of the original MixingVolume. For #695 Please enter the commit message for your changes. Lines starting
Connector is only active if Boolean variable use_m_wat_flow is set to true. For #695
Redeclaration can be done in the top model. For #695
Is added to add latent heat output in new human model, that is extended from this model For #695
Is extended from human_SensibleHeatModel. Enhances existing model by moisture output and corresponding latent heat output. For #695
If moisture balance is considered the input connector is connected to the input of the MixingVolumeMoistAir. Renames boolean variable and connector For #695
This model is extended from the ThermalZone. It redeclares the Air volume to the MixingVolumeMoistAir and sets the boolean parameter use_moisture_balance to true. Thus the moisture balance is considered. Still there is an error when checking. If setting up a simulation this error does not occur. Has to be checked. For #695
Is now also depending on ATot>0. This solves problems in check of ThermalZoneMoistAir.mo For #695
- Moisture splitting analogue to thermal splitter in RC - Model for calculating relative humidity from absolute humidty and dry bulb temperature For #695
… with normal thermalZone #695
…nalGainsMode parameter #695
Due to errors in examples of SimpleRoom Adds necessary redeclarations in ThermalZoneMoistAir For #695
…ub.com/RWTH-EBC/AixLib into issue695_AddMoistureBalanceThermalZone
removes wrong multiplication with temperature For #695
fixes bug in MultiZone models with moisture balance. For #695
Deletes auto-generated lines due to merge
For #770 |
closes #695 |
This was referenced Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #695 .