Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add integration testing with real S3. Partial fix #151, #156 #158

Merged
merged 25 commits into from
Dec 22, 2017
Merged

[WIP] Add integration testing with real S3. Partial fix #151, #156 #158

merged 25 commits into from
Dec 22, 2017

Conversation

menshikh-iv
Copy link
Contributor

Partial fix of #151 (for S3) and small cleanup according to #156.

@menshikh-iv menshikh-iv requested a review from mpenkov December 13, 2017 14:12
mpenkov
mpenkov approved these changes Dec 13, 2017
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpenkov
mpenkov approved these changes Dec 14, 2017
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Dec 14, 2017 •
edited by mpenkov
Loading

What else needed

mpenkov added 10 commits December 17, 2017 23:09
@mpenkov
Copy link
Collaborator

mpenkov commented Dec 21, 2017

4bf0e11 intentionally breaks the build to test that travis actually exits on error. 800b787 unbreaks it.

2dec2b4 is a mistake. a43541f corrects the mistake.

@menshikh-iv
return getdefaultencoding (mimic to open) + fix missing deps for in…
6a5f467 
…tegration-tests + fix benchmark encoding problem
mpenkov
mpenkov approved these changes Dec 22, 2017
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good to merge.

@menshikh-iv menshikh-iv merged commit 6f3a698 into master Dec 22, 2017
@menshikh-iv menshikh-iv deleted the s3-real-testing branch December 22, 2017 03:45
@menshikh-iv menshikh-iv mentioned this pull request Apr 15, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menshikh-iv @mpenkov