Get rid of code used only for Py2.6 compatibility #156
Comments
menshikh-iv
added a commit
that referenced
this issue
Dec 22, 2017
(#158) * add extra_req[test] (for pip) * basic code that make possible to run tests with real S3 * remove py26 outdated stuff * fix pep * Enable real s3 testing for 27, 36 with encrypted credentials + fixes for Travis * fix travisfile * fix travis[2] * try to understand what happens with travis * fix travis[3] * use different bucket to avoiding raise condition * generate unique bucket name (prevent race condition) + cleanup S3 after tests * move api keys to global, add benchmark * add explicit encoding for file + run bench in script session + fix path * fix assert + add distinct buckets for benchmark results * get tests running under Py2.7 * update integration test documentation * Avoid race condition during integration tests Several py2.7/py3.6 tests may be running at the same time, so we want to make sure they face different keys to avoid a race condition * remove quotes to keep travis happy * add missing semicolon * fail the build if integration tests fail * deliberately fail travis build to check .travis.yml * Revert "fail the build if integration tests fail" This reverts commit 3061f5b. * Revert "Revert "fail the build if integration tests fail"" This reverts commit 2dec2b4. * Revert "deliberately fail travis build to check .travis.yml" This reverts commit 4bf0e11. * return getdefaultencoding (mimic to `open`) + fix missing deps for integration-tests + fix benchmark encoding problem
mpenkov
added a commit
that referenced
this issue
May 5, 2018
We no longer support Py2.6, and GzipFile/BZ2File have been context managers since Py2.7, so these closing are no longer necessary. This addresses Issue #156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some parts of the code, like the closings around GzipFile and Bz2File, were only necessary while we supported Py2.6. Since we no longer support Py2.6, that code is not necessary. In the case of GzipFile and Bz2File, they are context managers in their own right since Py2.7, and the closing is redundant.
The text was updated successfully, but these errors were encountered: