Fix undefined name uri -> parsed_uri in smart_open_lib
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes piskvorky#213 __NameError__s would be raised in these instances instead of the intended __RuntimeError__s because __uri__ is an _undefined name_ in these contexts.
|
Thanks @cclauss . How did this bug get in? @menshikh-iv @mpenkov Now I'm wondering if there may be other cases, perhaps introduced by the same refactoring…? @cclauss can you add a unit test, to make sure we prevent regressions? |
|
@piskvorky not refactoring, this happens in #191. UPD: issue created #216 |
menshikh-iv
changed the title
uri -> parsed_uri in smart_open_lib
|
@cclauss thanks for fix, congratz with your first contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
NameError would be raised in these instances instead of the intended RuntimeError because uri is an undefined name in these contexts.