Skip to content

fix: Re-enable shadow block converter test #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenHenning merged 2 commits into from
May 15, 2025
Merged

fix: Re-enable shadow block converter test #2529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
382cc24
fix: Re-enable tests.
BenHenning May 15, 2025
1a63691
chore: Empty commit to re-trigger CI.
BenHenning May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/shadow-block-converter/test/shadow_block_converter_test.mocha.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const {shadowBlockConversionChangeListener} = require('../src/index');

const assert = chai.assert;

suite.skip('shadowBlockConversionChangeListener', function () {
suite('shadowBlockConversionChangeListener', function () {
/**
* Create a parent block with an unconnected value connection.
* @param {Blockly.Workspace} workspace The workspace to use.
Expand All @@ -38,6 +38,8 @@ suite.skip('shadowBlockConversionChangeListener', function () {
'<!DOCTYPE html><div id="blocklyDiv"></div>',
{pretendToBeVisual: true},
);
// See https://github.com/google/blockly-samples/issues/2528 for context.
global.SVGElement = window.SVGElement;

this.workspace = Blockly.inject('blocklyDiv');
this.workspace.addChangeListener(shadowBlockConversionChangeListener);
Expand Down
Loading