fix: Re-enable shadow block converter test #2529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a workaround to ensure SVGElement is actually present in the global namespace when running these tests.
BenHenning
requested review from
rachel-fenichel
and removed request for
RoboErikG
rachel-fenichel
approved these changes
May 15, 2025
BenHenning
merged commit 1f5d169
into
RaspberryPiFoundation:rc/v12.0.0
11 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2525
Proposed Changes
This re-enables the shadow block converter test disabled in #2524.
Reason for Changes
It's preferable to not keep tests disabled as it's easy to forget about them (and having them disabled increases the risk of discovering regressions being delayed or never noticed).
This particular fix is discussed in #2528. It's a bit complicated exactly how the global namespace is managed via
jsdom-global, but essentiallySVGElement(made available to Node.js viajsdom) is not being automatically bound to the global namespace and this works around the issue.Test Coverage
N/A -- This is a test-only change.
Documentation
No documentation changes are needed.
Additional Information
This is a slightly ugly workaround, but it seems viable for the medium-term while #2528 is considered.