chore: update to v12 beta 6 #2524
Conversation
This was inadvertently broken by a mistranscription in PR RaspberryPiFoundation#2453.
Method on superclass became public in v12.0.0.
Workaround for removal of that constant in RaspberryPiFoundation/blockly#8738.
This reverts commit 6e9d3fe.
|
this isn't ready for review yet, idk how to make it a draft after the fact edit: ready now if tests pass |
BenHenning
left a comment
BenHenning
left a comment
There was a problem hiding this comment.
Thanks @maribethb! Just a few small comments, but approving since CI is green and this generally looks good.
| # failed after a package had its version updated on github but before | ||
| # that version was published to npm. | ||
|
|
||
| name: publish unpublished plugins |
There was a problem hiding this comment.
| name: publish unpublished plugins | |
| name: Publish unpublished plugins |
For consistency.
There was a problem hiding this comment.
This was done from merging in master, I don't want to muddy up actual changes into what should be a merge commit. Anyway, the publish action was already lower case so it's not really any more inconsistent than publish already is
| * @param obj The object to test. | ||
| * @returns True iff the object conforms to ImageProperties. | ||
| */ | ||
| function isImageProperties(obj: any): obj is ImageProperties { |
There was a problem hiding this comment.
Perhaps this would be worth adding to Core proper in the future. Worth filing an issue?
| const assert = chai.assert; | ||
|
|
||
| suite('shadowBlockConversionChangeListener', function () { | ||
| suite.skip('shadowBlockConversionChangeListener', function () { |
There was a problem hiding this comment.
Should we perhaps file a TODO to re-enable these and add a line comment here pointing to that issue?
Or, do these pass now that the package-lock.json file has been corrected?
## The basics - [x] I [validated my changes](https://developers.google.com/blockly/guides/contribute/samples#making_and_verifying_a_change) ## The details ### Resolves Fixes #2525 ### Proposed Changes This re-enables the shadow block converter test disabled in #2524. ### Reason for Changes It's preferable to not keep tests disabled as it's easy to forget about them (and having them disabled increases the risk of discovering regressions being delayed or never noticed). This particular fix is discussed in #2528. It's a bit complicated exactly how the global namespace is managed via `jsdom-global`, but essentially `SVGElement` (made available to Node.js via `jsdom`) is not being automatically bound to the global namespace and this works around the issue. ### Test Coverage N/A -- This is a test-only change. ### Documentation No documentation changes are needed. ### Additional Information This is a slightly ugly workaround, but it seems viable for the medium-term while #2528 is considered.
4 participants
My turn to do #2523
Blockly.Field.NBSPexists again