Use new location for genUid on Blockly.utils.idGenerator
#876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alschmiedt
approved these changes
Sep 8, 2021
Contributor
alschmiedt
left a comment
alschmiedt
left a comment
There was a problem hiding this comment.
Lgtm once the lint error is fixed.
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Sep 8, 2021
Tests will fail until RaspberryPiFoundation/blockly-samples#876 is merged and published (as 2.1.0 or later), due to code in the dev-tools package attempting to stub genUid in its previous location.
4 tasks
Probe for and, if found, stub the new location.
cpcallen
force-pushed
the
genUid-move
branch
from
15577b8 to
9a90247
Compare
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Sep 9, 2021
Tests will fail until RaspberryPiFoundation/blockly-samples#876 is merged and published (as 2.6.0 or later), due to code in the dev-tools package attempting to stub genUid in its previous location.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genUidis being moved fromBlockly.utilstoBlockly.utils.idGenerator. Probe for the new location and, if found, stub it there instead of the old location.See RaspberryPiFoundation/blockly#5441.