Rename Blockly.utils.IdGenerator to idGenerator and move Blockly.utils.genUid to there
#5441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests will fail until RaspberryPiFoundation/blockly-samples#876 is merged and published (as 2.6.0 or later), due to code in the dev-tools package attempting to stub genUid in its previous location.
cpcallen
force-pushed
the
idGenerator
branch
from
3422b9d to
a90e45c
Compare
rachel-fenichel
approved these changes
Sep 9, 2021
cpcallen
added a commit
that referenced
this pull request
Sep 10, 2021
Running `npm run build:deps` makes a change to tests/deps.js that appears to have been inadvertently omitted from PR #5441. This commits that change.
cpcallen
added a commit
that referenced
this pull request
Sep 10, 2021
This was referenced Feb 14, 2022
alschmiedt
pushed a commit
to RaspberryPiFoundation/blockly-samples
that referenced
this pull request
Feb 15, 2022
* fix: Blockly.utils.genUid was deprecated fix: The following warning occurred while using backpack. Blockly.utils.genUid was deprecated on September 2021 and will be deleted on September 2022. Use Blockly.utils.idGenerator.genUid instead. The version of blockly has been upgraded to Q4 2021. Perhaps the following changes are involved: RaspberryPiFoundation/blockly#5441 * fix: Change required version
alschmiedt
pushed a commit
to RaspberryPiFoundation/blockly-samples
that referenced
this pull request
Feb 18, 2022
* fix: Blockly.utils.genUid was deprecated fix: The following warning occurred while using backpack. Blockly.utils.genUid was deprecated on September 2021 and will be deleted on September 2022. Use Blockly.utils.idGenerator.genUid instead. The version of blockly has been upgraded to Q4 2021. Perhaps the following changes are involved: RaspberryPiFoundation/blockly#5441 * fix: Change required version * fix: update homepage url * fix: added #readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_modulenpm test.(Tests will fail until the
dev-toolspackage from blockly-samples is published.)The details
Resolves
Part of #5026
Proposed Changes
Blockly.utils.IdGeneratormodule toBlockly.utils.idGenerator(because does not have a class as its default export).genUidfromBlockly.utilstoBlockly.utils.idGenerator, and provide a mechanism to allow it to be stubbed for tests in a way that should continue to work despite ongoing module migration work.Test Coverage
Awaiting push of
dev-toolspackage from blockly-samples. Tests will fail until then.Additional Information
See also RaspberryPiFoundation/blockly-samples#876.