Changed Abstract Field to New Configuration Paradigm #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feature/AbstractFieldConfig
branch
from
ae90468 to
4f411d2
Compare
core/field.js
Outdated
| } | ||
| tooltip && this.setTooltip(tooltip); | ||
|
|
||
| // TODO: Possibly eventually add configurations like cursor and css class. |
Collaborator
There was a problem hiding this comment.
Make this a reference to a github issue or remove.
rachel-fenichel
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #2722
Proposed Changes
Adds an opt_config property to the abstract field that adds a tooltip to the field.
Reason for Changes
Standardization of Configuration.
sounds like a rap they'd make you do in school
Test Coverage
Added tests for:
Also moved setTooltip function tests into the new configuration suite.
Tested on:
Documentation
Tooltip documentation already has a tracking issue: #2706
but it needs to be updated to include info about the opt_config property when constructing the field in JavaScript. (updates incomming)
Additional Information
N/A