Added script and workflow to automatically update build artifact sizes in check_metadata.sh #4997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ws](https://github.com/websockets/ws) from 7.4.4 to 7.5.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.4...7.5.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.19...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…s in check_metadata.sh
cpcallen
reviewed
Jul 8, 2021
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
I was going to suggest that you add a flag to check_metadata.sh to do this, rather than creating a separate script, but I've learned that bash acts weirdly in the face of self-modifying shell scripts so you'd want to store the target sizes and history data in a separate file. (There are ways to make self-modifying bash scripts work safely but… yikes.)
Comment on lines
+13
to
+19
| replacement="# ${quarter} ${version} ${blockly_size}\nblockly_size_expected=${blockly_size}" | ||
| sed -ri "s/blockly_size_expected=[0-9]+/${replacement}/g" tests/scripts/check_metadata.sh | ||
| replacement="# ${quarter} ${version} ${blocks_size}\nblocks_size_expected=${blocks_size}" | ||
| sed -ri "s/blocks_size_expected=[0-9]+/${replacement}/g" tests/scripts/check_metadata.sh | ||
| replacement="# ${quarter} ${version} ${blockly_gz_size}\nblockly_gz_size_expected=${blockly_gz_size}" | ||
| sed -ri "s/blockly_gz_size_expected=[0-9]+/${replacement}/g" tests/scripts/check_metadata.sh | ||
| replacement="# ${quarter} ${version} ${blocks_gz_size}\nblocks_gz_size_expected=${blocks_gz_size}" |
Collaborator
Collaborator
There was a problem hiding this comment.
Oh, also: see [style guide re: line length and long string literals](replacement="# ${quarter} ${version} ${blockly_size}\nblockly_size_expected=${blockly_size}").
Contributor
Author
There was a problem hiding this comment.
Yeah, I noticed the delimiter issue and decided to just go with the most recent, but having it be consistent SGTM, will hold off until that change is in.
…npm_and_yarn/ws-7.5.1 Bump ws from 7.4.4 to 7.5.1
…npm_and_yarn/lodash-4.17.21 Bump lodash from 4.17.19 to 4.17.21
…pengine_demos_master Appengine deploy workflow on master for testing
Previous path was `_deploy/`. New path is `../_deploy`.
…chel-patch-1 Get deploy files from the correct directory
…rryPiFoundation#5006) * Create develop_freeze_comment.yml * Update comments * Fix typo and update uses * Add test message
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.4 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.4...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-rachel-fenichel-patch-1 Revert "Get deploy files from the correct directory"
Contributor
Author
|
I managed to clobber my branch, so I'm going to withdraw this PR and send a new one incorporating the changes you suggested. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#4977
Proposed Changes
Adds a script that calculates the size of the various Blockly JS files and updates check_metadata.sh with the new values.
Behavior Before Change
As part of the release process, a developer would need to manually determine the build artifact sizes and update the check_metadata.sh script.
Behavior After Change
Running the workflow will automatically calculate the new build artifact sizes, update the script, and create a PR with the updated script.
Reason for Changes
Makes this step in the release process more reliable and reduces the effort on the part of the dev team.