Added script and workflow to automatically update build artifact sizes in check_metadata.sh #5033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in check_metadata.sh
Closed
3 tasks
cpcallen
reviewed
Jul 13, 2021
gonfunko
commented
Jul 13, 2021
Contributor
Author
gonfunko
left a comment
gonfunko
left a comment
There was a problem hiding this comment.
Thanks for the review! Incorporated your suggested changes, PTAL!
cpcallen
reviewed
Jul 14, 2021
cpcallen
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#4977
Proposed Changes
Adds a script that calculates the size of the various Blockly JS files and updates check_metadata.sh with the new values.
Behavior Before Change
As part of the release process, a developer would need to manually determine the build artifact sizes and update the check_metadata.sh script.
Behavior After Change
Running the workflow will automatically calculate the new build artifact sizes, update the script, and create a PR with the updated script.
Reason for Changes
Makes this step in the release process more reliable and reduces the effort on the part of the dev team.