Migrate core/utils/useragent.js to goog.module syntax #5396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
Aug 19, 2021
| Blockly.utils.userAgent.IE; | ||
| /** @type {boolean} */ | ||
| let IE; | ||
| exports.IE = IE; |
Contributor
There was a problem hiding this comment.
Does this approach work? It seems like these are all going to be exported as undefined since their values aren't set until later.
Collaborator
There was a problem hiding this comment.
Yeah: that is not going to work. For a bunch of exported booleans that are only referenced (in this module) for the purposes of setting other exported booleans, I'd suggest just setting them all directly on exports and not bothering with declaring local variables for them at all.
5 tasks
Collaborator
|
Oh dear. I'd forgotten that you were working on this, and inadvertently duplicated this work in #5435. My apologies. I'm going to close this, but feel free to reopen and/or submit a new PR correcting any problems with my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm run testlocally already.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/utils/useragent.jstogoog.modulesyntax.