Skip to content

Migrate core/utils/useragent.js to goog.module syntax #5435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpcallen merged 4 commits into from
Sep 7, 2021
Merged

Migrate core/utils/useragent.js to goog.module syntax #5435

cpcallen merged 4 commits into from
Sep 7, 2021

Conversation

@cpcallen
Copy link
Collaborator

@cpcallen cpcallen commented Sep 7, 2021

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test.

The details

Resolves

Part of #5026

Proposed Changes

Converts core/utils/useragent.js to goog.module with ES6 const/let.

Additional Information

@cpcallen cpcallen added this to the 2021_q3_release milestone Sep 7, 2021
@cpcallen cpcallen changed the base branch from master to goog_module September 7, 2021 17:45
@cpcallen cpcallen requested a review from a team as a code owner September 7, 2021 17:45
@cpcallen cpcallen merged commit 2d89a36 into RaspberryPiFoundation:goog_module Sep 7, 2021
@cpcallen cpcallen deleted the migrate-useragent branch September 7, 2021 17:48
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 7, 2021
@cpcallen cpcallen mentioned this pull request Sep 10, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

No one assigned

Labels

cla: yes Used by Google's CLA checker. type: cleanup

Projects

None yet

Milestone

2021_q3_release

Development

Successfully merging this pull request may close these issues.

2 participants

@cpcallen @rachel-fenichel