Skip to content

Math cleanup pass #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hollasch opened this issue Dec 19, 2020 · 3 comments
Closed

Math cleanup pass #839

hollasch opened this issue Dec 19, 2020 · 3 comments

Comments

@hollasch
Copy link
Collaborator

  • Use consistent indentation levels for our math blocks
  • Use equation alignment where appropriate
@hollasch hollasch added this to the v4.0.0 milestone Dec 19, 2020
@hollasch hollasch self-assigned this Dec 19, 2020
@ymherklotz
Copy link
Contributor

ymherklotz commented Aug 28, 2021

In case this is useful, I just noticed that the alignment of italic variables in math blocks didn't use \textit, which means the spacing looks a bit strange sometimes as they are basically independent letters.

I have made the changes for all variables like that in Book3 (https://github.com/ymherklotz/raytracing.github.io/tree/textit-in-mathblocks), and if this is useful and a wanted changed, I could make the same changes in Book1 and Book2.

These changes are based off of dev-major, so they should be easy to merge and up to date.

@hollasch
Copy link
Collaborator Author

Thank you! In most cases, this has only a very slight effect on kerning, but there are definitely cases where it's significant. Here's a good example:

Before:
pSurface-before

After:
pSurface-after

It's also proper markup, which would be enough to convince me.

Thanks again for the help -- converting the other two books would be most appreciated, based on the dev-major branch. Also, please add yourself to acknowledgements.html, and add a new v4.0.0 entry in changelog.md.

@hollasch hollasch modified the milestones: v4.0.0, v4.0.0-rel Sep 8, 2021
hollasch added a commit that referenced this issue Jul 15, 2023
- Use \mathit{...} to mark variables
- Use \operatorname{...} to mark operators/functions

Plus additional small fixes.

Resolves #839
hollasch added a commit that referenced this issue Jul 17, 2023
- Use \mathit{...} to mark variables
- Use \operatorname{...} to mark operators/functions

Plus additional small fixes.

Resolves #839
hollasch added a commit that referenced this issue Jul 17, 2023
- Use \mathit{...} to mark variables
- Use \operatorname{...} to mark operators/functions

Plus additional small fixes.

Resolves #839
@hollasch
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants