Default type on input set as attribute

[sreynen]

This is my test case:

const bel = require('bel');
console.log(bel`<input type="hidden" name="name" value="value" />`.toString());

Which currently outputs <input type="text" type="hidden" name="test" value="" /> when min-document is being used via global, within node.

I'm not sure where or why the type property is rendered as an attribute, but it seems like it should be set as an attribute rather than a property, which removes the duplicate rendered attribute.

[yoshuawuyts]

I think this looks reasonable; If it's not too much trouble, could you perhaps add a test to catch future regressions? Thanks! ✨

[sreynen]

I added a test, and also updated the test this had broken.

[mplatt]

@Raynos any chance we could get this in?

[Raynos]

👎 Please do both or only properties.

Properties are source of truth, attributes are just a weird bag of stuff.

[sreynen]

If properties are the source of truth, then I guess bel needs to be updated (around https://github.com/shama/bel/blob/master/index.js#L92) to set type as a property rather than an attribute. Is there any documentation of which attributes rely on properties?

[sreynen]

After looking at this more, I think I understand it better. Here's what I've found:

1. What bel does works with browser DOM, so the change needs to happen in min-document.
2. Specifically, what needs to change is the attribute type and the property type should be the same thing, on both set and get, as they are in browser DOM.
3. And because min-document outputs both attributes and properties, only one of the two should ever get set to prevent duplicate type= output.
4. As there are no getters and setters on properties that would allow setting attributes instead, this must go the other way, setting and getting the property any time the attribute is set or get.

Updated PR does that by changing DOMElement.prototype.setAttributeNS and DOMElement.prototype.getAttributeNS so they set and get the property rather than attribute for input type.

[Raynos]

This is great, thanks @sreynen

I like this solution.

[Raynos]

Fixed in 2.19.0

[clehner]

I ran into this bug and was directed to this PR. Could 2.19.0 be published to npm please?

[clehner]

Never mind, my cache was stale. Carry on!