Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow grouping on doubles #1728

Closed
arunsrinivasan opened this issue Jun 4, 2016 · 2 comments
Closed

disallow grouping on doubles #1728

arunsrinivasan opened this issue Jun 4, 2016 · 2 comments
Labels
High internals

Comments

@arunsrinivasan
Copy link
Member

Following this SO post, the best way forward would be to remove the functionality of grouping on columns of type double (at least those that are really double). Dirk mentions this under the comment to my answer, and I agree.

The other option would be to providing a warning, but there'll be those who'd post that warning and that they don't understand. Removing the functionality is also a cleaner solution since it doesn't really make much sense to group-by on floats. Error-ing with a warning to switch the column to bit64::integer64 makes a lot of sense.
@arunsrinivasan
Copy link
Member Author

arunsrinivasan commented Jun 4, 2016 •
edited
Loading

This is also related to #1642. If this goes away, then ordering can be performed without any rounding, but the issue would be to take care of binary search based subsets, since groups are decided while ordering.

arunsrinivasan added a commit that referenced this issue Jul 21, 2016
@arunsrinivasan
Handles #1642, #1728, #1463, #485. Full precision grouping/ordering/j…
f982e2e 
…oining by default, i.e., no rounding.
@arunsrinivasan
Copy link
Member Author

Default is not to do rounding for now..

arunsrinivasan added a commit that referenced this issue Jul 21, 2016
@arunsrinivasan
#1642, #1728, #1463, #485 full precision, also update init.c.
7a17da2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arunsrinivasan