Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-Forge #5445] numeric rounding should be 0 or 1 automatically for POSIXct #485

Open
arunsrinivasan opened this issue Jun 8, 2014 · 3 comments
Open

[R-Forge #5445] numeric rounding should be 0 or 1 automatically for POSIXct #485

arunsrinivasan opened this issue Jun 8, 2014 · 3 comments
Assignees
@mattdowle
Labels
bug

Comments

@arunsrinivasan
Copy link
Member

Submitted by: Matt Dowle; Assigned to: Nobody; R-Forge link

As highlighted here on SO.

Users shouldn't need to know or call setNumericRounding for this.
@arunsrinivasan arunsrinivasan added this to the v1.9.4 milestone Jun 19, 2014
@arunsrinivasan arunsrinivasan removed this from the v1.9.4 milestone Jun 26, 2014
@arunsrinivasan arunsrinivasan mentioned this issue May 28, 2015
Merged
@arunsrinivasan arunsrinivasan added this to the v2.0.0 milestone Dec 2, 2015
@mattdowle
Copy link
Member

Note also ?setNumericRounding contains "[1 will] become the default for POSIXct types in the future, instead of the default 2." to update when done.
Further, if you have 2 column join/group, both numeric, one POSIXct and the other say stock prices (fixed decimal precision), then you'd want it to use the appropriate rounding for the column. But we can only control one global rounding level currently.

arunsrinivasan added a commit that referenced this issue Jul 21, 2016
@arunsrinivasan
Handles #1642, #1728, #1463, #485. Full precision grouping/ordering/j…
f982e2e 
…oining by default, i.e., no rounding.
@arunsrinivasan
Copy link
Member Author

Default is not to do rounding for now..

arunsrinivasan added a commit that referenced this issue Jul 21, 2016
@arunsrinivasan
#1642, #1728, #1463, #485 full precision, also update init.c.
7a17da2
@mattdowle
Copy link
Member

Not fully sure but iiuc we now don't do rounding at all. Which was good move for now. Reopening to come back to this in 1.9.10 and do the appropriate rounding as intended.

@mattdowle mattdowle reopened this Nov 23, 2016
@mattdowle mattdowle mentioned this issue Nov 23, 2016
Closed
@mattdowle mattdowle self-assigned this Nov 23, 2016
@mattdowle mattdowle removed this from the Candidate milestone May 10, 2018
@jangorecki jangorecki removed the High label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattdowle mattdowle

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattdowle @arunsrinivasan @jangorecki