-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect nomatch = 0L
for integer i
#3109
Comments
For the second part, the inconsistent behavior is good, right? I generally don't want a warning when part of an anti-join matches nothing, but do want it when I pass a row number outside of range. There are other safeguards on row numbers that don't have join analogies too (eg, |
Well, I'm not sure about it. Base R also does not give a warning: x = 1:10
x[-11L] # no warning, works fine
x[c(-1L,1L)] # also an exception |
please use |
nomatch = 0L
for integer inomatch = 0L
for integer i
Currently
nomatch
seems to be ignored ifi
indt[i, j, nomatch = 0L]
is integer. Values ofi
which are out of bounds orNA
result in rows filled withNA
:I see no reason to not support
nomatch = 0L
for integeri
.Also note that the current handling of negative integer
i
seems to be inconsistent with not-joins:The text was updated successfully, but these errors were encountered: