Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain nomatch=FALSE for backwards compatibility #5214

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

mattdowle
Copy link
Member

@mattdowle mattdowle commented Oct 11, 2021

Resolves revdeps NADIA and VIM (highlighted in #5208) which use nomatch=FALSE. Were broken by #4353.

@mattdowle mattdowle added this to the 1.14.3 milestone Oct 11, 2021
@mattdowle mattdowle added the dev label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #5214 (9fdd0de) into master (a41ae4a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9fdd0de differs from pull request most recent head 0ef4c72. Consider uploading reports for the commit 0ef4c72 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5214   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          77       77           
  Lines       14531    14531           
=======================================
  Hits        14459    14459           
  Misses         72       72           
Impacted Files Coverage Δ
R/data.table.R 99.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41ae4a...0ef4c72. Read the comment docs.

@mattdowle mattdowle merged commit 36279f4 into master Oct 11, 2021
@mattdowle mattdowle deleted the nomatch_FALSE branch October 11, 2021 20:53
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants