Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore nomatch=NA_character_ #5216

Merged
merged 2 commits into from
Oct 12, 2021
Merged

restore nomatch=NA_character_ #5216

merged 2 commits into from
Oct 12, 2021

Conversation

mattdowle
Copy link
Member

Resolves revdep SpaDES.Core (highlighted in #5208) which uses nomatch=NA_character_. Similar to #5214, #4353 also broke it; there was an as.integer(nomatch) before.

@mattdowle mattdowle added the dev label Oct 12, 2021
@mattdowle mattdowle added this to the 1.14.3 milestone Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #5216 (aa0d7fd) into master (36279f4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5216   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          77       77           
  Lines       14531    14537    +6     
=======================================
+ Hits        14459    14465    +6     
  Misses         72       72           
Impacted Files Coverage Δ
R/data.table.R 99.89% <100.00%> (+<0.01%) ⬆️
src/bmerge.c 99.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36279f4...aa0d7fd. Read the comment docs.

@mattdowle mattdowle merged commit 4e78049 into master Oct 12, 2021
@mattdowle mattdowle deleted the nomatch_character_NA branch October 12, 2021 08:21
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants