Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

RxJS v3.0.1 with TypeScript 1.6.0 dev branch cannot compile on ES6 target with noImplicitAny option #857

Closed
tetsuharuohzeki opened this issue Aug 14, 2015 · 3 comments
Closed

RxJS v3.0.1 with TypeScript 1.6.0 dev branch cannot compile on ES6 target with noImplicitAny option #857

tetsuharuohzeki opened this issue Aug 14, 2015 · 3 comments

Comments

@tetsuharuohzeki
Copy link
Contributor

env

compiler version & rxjs

  • typescript@1.6.0-dev.20150814
  • rx@3.0.1

steps to reproduce

$(npm bin)/tsc --noImplicitAny --target ES6 node_modules/rx/ts/es6/rx.all.d.ts

result

node_modules/rx/ts/es6/rx.all.d.ts(222,31): error TS7006: Parameter 'child' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(222,38): error TS7006: Parameter 'parent' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(223,36): error TS7006: Parameter 'obj' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(535,18): error TS7006: Parameter 'scheduler' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(535,29): error TS7006: Parameter 'state' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(535,36): error TS7006: Parameter 'period' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(535,44): error TS7006: Parameter 'action' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,17): error TS7006: Parameter 'kind' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,23): error TS7006: Parameter 'value' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,30): error TS7006: Parameter 'exception' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,41): error TS7006: Parameter 'accept' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,49): error TS7006: Parameter 'acceptObservable' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(653,67): error TS7006: Parameter 'toString' implicitly has an 'any' type.
node_modules/rx/ts/es6/rx.all.d.ts(4433,9): error TS7010: 'transduce', which lacks return-type annotation, implicitly has an 'any' return type.

remarks
@tetsuharuohzeki tetsuharuohzeki mentioned this issue Aug 14, 2015
Merged
dokidokivisual added a commit to karen-irc/karen that referenced this issue Aug 14, 2015
@dokidokivisual
Auto merge of #305 - saneyuki:fix, r=saneyuki
ed05893 
Lock RxJS 3.0.0

This is workaround fix for Reactive-Extensions/RxJS#857

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/karen-irc/karen/305)
<!-- Reviewable:end -->
@david-driscoll
Copy link
Contributor

It's very possible I'll look at it asap.

@david-driscoll
Copy link
Contributor

Yeah I just saw a few random places where any was missing, I'll tack this into #859

@mattpodwysocki
Copy link
Member

@saneyuki @david-driscoll merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattpodwysocki @tetsuharuohzeki @david-driscoll