Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Rewrite typescript declarations #848

Merged
merged 2 commits into from
Aug 11, 2015

Conversation

david-driscoll
Copy link
Contributor

This is a rewrite of the .d.ts files from the ground up, using the existing src files as a reference. Most things have ported over, others have been updated to match RxJS 3.0.

There a are a few things left to do still, so this PR is very much a work in progress. I'd love to hear thoughts to see if you guys think this is a right direction or not.

  • Automate creation of .d.ts files (core, all, aggregates, etc) as part of the grunt build
  • Support ES6 use cases (iterables, map, set, etc)
  • Support Node.js use cases (streams)

@ghost
Copy link

ghost commented Aug 7, 2015

Hi @david-driscoll, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.

TTYL, MSOTBOT;

@ghost ghost added the cla-already-signed label Aug 7, 2015
@@ -0,0 +1,12 @@
{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to drop this file and squash the commits before the PR is finished.

@david-driscoll david-driscoll changed the title [wip] Rewrite typescript declarations Rewrite typescript declarations Aug 8, 2015
@david-driscoll
Copy link
Contributor Author

I've tested this against the Omnisharp-atom code base (we use RxJs quiet a bit) everything looks to be working pretty well from a definitions point of view.

mattpodwysocki added a commit that referenced this pull request Aug 11, 2015
Rewrite typescript declarations
@mattpodwysocki mattpodwysocki merged commit 7d4fc91 into Reactive-Extensions:master Aug 11, 2015
@mattpodwysocki
Copy link
Member

@david-driscoll currently working on this branch if you are curious about the changes https://github.com/Reactive-Extensions/RxJS/tree/scheduler_refactor

@david-driscoll
Copy link
Contributor Author

Cool, that looks fairly straightforward.

@mattpodwysocki
Copy link
Member

@david-driscoll can you please fix the build and the nuget packages please?

@david-driscoll
Copy link
Contributor Author

sure thing.

On Fri, Aug 14, 2015 at 4:12 PM, Matthew Podwysocki <
notifications@github.com> wrote:

@david-driscoll https://github.com/david-driscoll can you please fix
the build and the nuget packages please?


Reply to this email directly or view it on GitHub
#848 (comment)
.

@electricessence
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants