[regression] v4.0.0's TypeScript definition don't include Observable.prototype.merge<T>().

[tetsuharuohzeki]

environment

• RxJS v4.0.0
• At least, I confirm this regression in rx.all.d.ts and rx.all.es6.d.ts.

actual

• v4.0.0's type definitions for TypeScript don't include Observable.prototype.merge<T>().
  • They includes only ObservableStatic.merge<T>()
• I think this is regression because:
  • this is not noted in release note
  • the original definition is still in this repository: https://github.com/Reactive-Extensions/RxJS/blob/7d4fc916c1f296b32402ca1b9eb995d3ee1a0d7a/ts/core/linq/observable/mergeproto.ts

[mattpodwysocki]

Once again, @david-driscoll is there a reason for the regression? Did I screw up?

[david-driscoll]

Not sure, I'll take a look tonight.

On Mon, Oct 5, 2015 at 10:24 AM, Matthew Podwysocki <
notifications@github.com> wrote:

Once again, @david-driscoll https://github.com/david-driscoll is there
a reason for the regression? Did I screw up?

—
Reply to this email directly or view it on GitHub
#931 (comment)
.

[mattpodwysocki]

@david-driscoll appreciate it, that and the zip one. Not sure if I'm doing something wrong here. I'll wait until this before 4.0.1 goes out the door if you don't mind

[david-driscoll]

I always take the blame first. :) It's possible the way things are loaded
through grunt has a hole or two.

On Mon, Oct 5, 2015 at 10:39 AM, Matthew Podwysocki <
notifications@github.com> wrote:

@david-driscoll https://github.com/david-driscoll appreciate it, that
and the zip one. Not sure if I'm doing something wrong here

—
Reply to this email directly or view it on GitHub
#931 (comment)
.

[david-driscoll]

Sorry been distracted with life... I think I see the problem.

Merge currently lives under https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/linq/observable/mergeconcat.js instead of mergeproto.js, it should be as simple as renaming.

I'm not sure if the zip one is the same, but I'm going to look at these tonight after I get kids squared away. 😄

[david-driscoll]

okay I lied... I looked at the zip one too.

zipproto has been rolled into https://github.com/Reactive-Extensions/RxJS/blob/master/src/core/perf/operators/zip.js and zipproto isn't in the grunt file. I'll get a pr out for these two tonight.

[baltie]

Heh, we looked into this at the same time, see #932. ;) I actually had a fix for the merge operator issue and was just about to create a PR for it. Now I see you have the exact same fix in mind. I'll leave you to it, @david-driscoll. :)

[tetsuharuohzeki]

This is also fixed by #970 in the same way as #932.