[regression] v4.0.0's TypeScript definition don't include Observable.prototype.zip().

[tetsuharuohzeki]

environment

• RxJS v4.0.0
• At least, I confirm this regression in rx.all.d.ts and rx.all.es6.d.ts.

actual

• v4.0.0's type definitions for TypeScript don't include Observable.prototype.zip().
  • They includes only ObservableStatic.zip()
• I think this is regression because:
  • this is not noted in release note
  • the original definition is still in this repository: https://github.com/Reactive-Extensions/RxJS/blob/146384d9943bd3b1e692a83f199a73c9e4a3d193/ts/core/linq/observable/zipproto.ts

[mattpodwysocki]

@david-driscoll is there a reason for this not being in the all, because I see zipproto.ts in there...

[david-driscoll]

Not sure! I'll have a look tonight.

On Mon, Oct 5, 2015 at 10:21 AM, Matthew Podwysocki <
notifications@github.com> wrote:

@david-driscoll https://github.com/david-driscoll is there a reason for
this not being in the all, because I see zipproto.ts in there...

—
Reply to this email directly or view it on GitHub
#932 (comment)
.

[baltie]

@mattpodwysocki @david-driscoll linq/observable/zipproto.js is not included in any concat target in Gruntfile.js any more. It used to be, but commit 5bacc78 changed that and replaced it with perf/operators/zip.js.

Because of that, zipproto.ts isn't included any more since it's corresponding js file is not a concat target. I'm not entirely sure what the proper fix is here. The rebuild-ts task depends on the names in perf/operators and linq/observable being unique regardless of location. If perf/operators/zip.js was renamed to perf/operators/zipproto.js, it would fix the TypeScript issue, but is that an acceptable change?

[tetsuharuohzeki]

@mattpodwysocki

The release note says this & #931 are fixed in v4.0.6, but the npm published archive don't include #970. v4.0.6 is tagged to a1f10de which is the commit before merging #970.