Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Node 20 on CI via GitHub Actions major upgrades #372

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

TWiStErRob
Copy link
Contributor

@TWiStErRob TWiStErRob commented Jan 27, 2024

Reduce warnings:

image

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, gradle/wrapper-validation-action@v1, actions/setup-java@v3, actions/cache@v3, gradle/gradle-build-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

wrapper-validation doesn't have a version yet: gradle/wrapper-validation-action#160 (it's quite possible it'll end up as gradle/actions/wrapper-validation@v2 in a few weeks)

Note: most actions treat Node 20 as major bumps because self-hosted runners break down from automatic minor bumps via @vX, if there's no Node 20 installed on them.

@TWiStErRob
Copy link
Contributor Author

Please run the manual workflow against this branch before merging.

@ychescale9
Copy link
Member

Thanks.

Please run the manual workflow against this branch before merging.

It doesn't look like I'm able to target your branch from the manual workflow UI 🤔

@TWiStErRob
Copy link
Contributor Author

Oops, you're right, the only thing you can do is add my fork as remote and push a branch to your origin. Or merge blindly and 🤞 😉.

@ychescale9
Copy link
Member

Cool, I'll merge then as the main workflow should cover most if not all your changes.

@ychescale9 ychescale9 merged commit 9d5d623 into ReactiveCircus:main Jan 27, 2024
6 of 7 checks passed
@TWiStErRob TWiStErRob deleted the node20 branch January 27, 2024 12:25
ychescale9 added a commit that referenced this pull request May 24, 2024
* main:
  Prepare for release 2.31.0.
  Install platforms for the specified api level (#384)
  Add api level `VanillaIceCream` support (#378)
  Bump Gradle wrapper validation from v1 to v2 to use Node 20 (#374)
  Migrate to Node 20 on CI via GitHub Actions major upgrades (#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants