Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Node.js to 20 #160

Closed
Tracked by #290
LVMVRQUXL opened this issue Oct 24, 2023 · 5 comments
Closed
Tracked by #290

Upgrading Node.js to 20 #160

LVMVRQUXL opened this issue Oct 24, 2023 · 5 comments
Milestone

Comments

@LVMVRQUXL
Copy link

LVMVRQUXL commented Oct 24, 2023

Because Node.js 16 actions are deprecated, it could be nice to upgrade this action to Node.js 20.

Here's an example of workflow using gradle/wrapper-validation-action@v1.0.6 that shows the corresponding deprecation notice: Kotools Types Integration #370.

Thank you for considering this issue.

@bigdaz
Copy link
Member

bigdaz commented Jan 29, 2024

This fix is available in the v2.0.0-rc.1 release.

Please use gradle/wrapper-validation-action@v2 instead of v1.

@LVMVRQUXL
Copy link
Author

This fix is available in the v2.0.0-rc.1 release.

Please use gradle/wrapper-validation-action@v2 instead of v1.

@bigdaz Do you have a visibility on when the version 2.0.0 will be available as a stable release (not only as a release candidate)?

@TWiStErRob
Copy link
Contributor

Thank you @bigdaz! I already saw it ran successfully without warning on 10 repos from a few different orgs.

@bigdaz
Copy link
Member

bigdaz commented Jan 29, 2024

Do you have a visibility on when the version 2.0.0 will be available as a stable release (not only as a release candidate)?

@LVMVRQUXL Likely a week or so: just want to let it soak a little. Unless we experience issues, the final release will be from the same commit.

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Jan 30, 2024

Note that by pushing v2 bots think that it's a stable release and most give no indication:
detekt/detekt#6918 (pinned Renovate)
gradle-nexus/publish-plugin#313 (non-pinned Renovate)
hiteshprajapati/fineract#109 (pinned Dependabot)
syoon2/Project-Diagram-Generator#47 (non-pinned Dependabot)

Only non-pinned Dependabot gets the release notes, so users see v2.0.0-rc.1 when they expand that.


Same happened with setup-gradle@v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants