fix(Subject): lift signature is now appropriate for stricter TS 2.4 c… #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 I think it's highly unlikely, unless someone uses |
hansl
approved these changes
Jul 4, 2017
Generated by 🚫 dangerJS |
--0.0KB-green.svg?style=flat-square){kind=icon}
--0.0KB-green.svg?style=flat-square){kind=icon}
…pt 2.4 checks Type safety wasn't really gauranteed with lift before because we survived for a long time with an incorrect type signature, TypeScript 2.4 introduces stricter type-checking, and all of a sudden `lift` on `Subject` was breaking builds for those that are riding the wave of the latest-and-greatest.
benlesh
changed the title
|
#2539 was closed, it appears, but because of CoC issues not due to it being tagged as resolved. Just for linking and clarity, it might be good to have it marked as fixed in the new release (unless that is not what this fix is claiming). Thanks for the quick resolve on this! |
|
#2540 - linking reference there to here, over similiar issue. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hecks
Type safety wasn't really gauranteed with lift before because we survived for a long time with an incorrect type signature, TypeScript 2.4 introduces stricter type-checking, and all of a sudden
liftonSubjectwas breaking builds for those that are riding the wave of the latest-and-greatest.EDIT: Upon review, really not sure of any way this change could break anyone. So I'm going to push this through as a patch. It was basically building with an incorrect type signature in TS 2.3 and lower, so correcting it should not break anyone's builds.