Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator BO.forEachFuture #646

Closed
wants to merge 1 commit into from
Closed

Operator BO.forEachFuture #646

wants to merge 1 commit into from

Conversation

akarnokd
Copy link
Member

Issue #634

I tried to find a random place in BO but it is likely this or the other PRs will not merge one after another.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #578 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

In Rx.Net it had clean design with Task and async/await. In Java we don't. This (and other similar pull requests) don't make much sense and are greatly complicating the API.

In Java the Future/FutureTask/Callable/Runnable/CompletableFuture set of classes do not play well with the non-blocking/reactive style of Rx, nor is there good conformity across JVM languages (Scala, Groovy, Clojure with different concurrency models and libraries) or even Java libraries (such as Guava and Akka).

I think that all of these additions you are proposing related to java.util.concurrent interop should be pushed into a separate contrib module and not part of core. Perhaps rxjava-contrib/rxjava-java-future or something along those lines?

In short, the goal is to keep rxjava-core focused on the basics of Observable and non-blocking operators. Interop with the various different approaches to concurrency should be kept separate. In retrospect even the Async.java stuff should likely be moved out to this new contrib module.

@akarnokd
Copy link
Member Author

Yes, a contrib module would be much cleaner.

@benjchristensen
Copy link
Member

Great, I'm glad we agree. I'll setup the module for you.

benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 27, 2013
@benjchristensen
New contrib module: rxjava-async-util
dda3b79 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
@benjchristensen benjchristensen mentioned this pull request Dec 27, 2013
Closed
@benjchristensen
Copy link
Member

Merge these into #696 instead.

benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 30, 2013
@benjchristensen
New contrib module: rxjava-async-util
16ea504 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 30, 2013
@benjchristensen
New contrib module: rxjava-async-util
def48d8 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 30, 2013
@benjchristensen
New contrib module: rxjava-async-util
210a4bb 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 30, 2013
@benjchristensen
New contrib module: rxjava-async-util
5370012 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
benjchristensen added a commit to benjchristensen/RxJava that referenced this pull request Dec 30, 2013
@benjchristensen
New contrib module: rxjava-async-util
cf33aad 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX#646 (comment)
- ReactiveX#645 (comment)
- ReactiveX#622 (comment)
@akarnokd akarnokd deleted the BOForEachFuture branch January 13, 2014 09:58
benjchristensen added a commit to ReactiveX/RxJavaAsyncUtil that referenced this pull request Aug 29, 2014
@benjchristensen
New contrib module: rxjava-async-util
e40fb11 
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core.

As per discussions at:

- ReactiveX/RxJava#646 (comment)
- ReactiveX/RxJava#645 (comment)
- ReactiveX/RxJava#622 (comment)
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@wantedlzx @RobWin
Issue ReactiveX#646: Illegal state transition from HALF_OPEN to OPEN/…
1876763 
…CLOSED. (ReactiveX#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akarnokd @cloudbees-pull-request-builder @benjchristensen