Issue ReactiveX#646: Illegal state transition from HALF_OPEN to OPEN/…

…CLOSED. (ReactiveX#647)
jihoonson · Sep 25, 2019 · 1876763 · 1876763
1 parent b88ffa7
commit 1876763
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/.../main/java/io/github/resilience4j/circuitbreaker/internal/CircuitBreakerStateMachine.java b/.../main/java/io/github/resilience4j/circuitbreaker/internal/CircuitBreakerStateMachine.java
@@ -653,11 +653,13 @@ private class HalfOpenState implements CircuitBreakerState {
 
         private CircuitBreakerMetrics circuitBreakerMetrics;
         private final AtomicInteger permittedNumberOfCalls;
+        private final AtomicBoolean isHalfOpen;
 
         HalfOpenState() {
             int permittedNumberOfCallsInHalfOpenState = circuitBreakerConfig.getPermittedNumberOfCallsInHalfOpenState();
             this.circuitBreakerMetrics = CircuitBreakerMetrics.forHalfOpen(permittedNumberOfCallsInHalfOpenState, getCircuitBreakerConfig());
             this.permittedNumberOfCalls = new AtomicInteger(permittedNumberOfCallsInHalfOpenState);
+            this.isHalfOpen = new AtomicBoolean(true);
         }
 
         /**
@@ -709,10 +711,14 @@ public void onSuccess(long duration, TimeUnit durationUnit) {
          */
         private void checkIfThresholdsExceeded(Result result) {
             if(result == ABOVE_THRESHOLDS){
-                transitionToOpenState();
+                if(isHalfOpen.compareAndSet(true, false)){
+                    transitionToOpenState();
+                }
             }
             if(result == BELOW_THRESHOLDS){
-                transitionToClosedState();
+                if(isHalfOpen.compareAndSet(true, false)){
+                    transitionToClosedState();
+                }
             }
         }